Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: skip dockerhub login if it's a PR #373

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

enapupe
Copy link
Contributor

@enapupe enapupe commented Dec 12, 2023

we are only pushing to docker hub if it's not a PR (i.e. main branch, tags). there's no point in performing dockerhub login if we are no pushing anything.

@enapupe enapupe requested a review from vnugent December 12, 2023 11:21
@vnugent vnugent merged commit cfada19 into develop Dec 12, 2023
4 checks passed
@vnugent vnugent mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants